Add limit to list workflows #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 6, 2024
| @@ -472,6 +473,11 @@ private async IAsyncEnumerable<WorkflowExecution> ListWorkflowsInternalAsync( | |||
| req, rpcOptsAndCancelSource.Item1).ConfigureAwait(false); | |||
| foreach (var exec in resp.Executions) | |||
| { | |||
| if (input.Options != null && input.Options.Limit > 0 && | |||
| yielded++ >= input.Options.Limit) | |||
There was a problem hiding this comment.
Not the biggest fan of side effects in conditionals like this since postfix increment operator precedence is not always easy for a code reader to understand, but not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
Convenience functionality since there's no built-in
takefunction or similar in .NET for async iteratorsChecklist
Closes [Feature Request]
ReplayWorkflowsAsyncshould takelimitparameter #332How was this tested:
Added test
Any docs updates needed?